Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdms: change get ms members return value #5547

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Feb 18, 2024

What problem does this PR solve?

What is changed and how does it work?

ref tikv/pd#7819

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e755e2a) 61.34% compared to head (347dc13) 67.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5547      +/-   ##
==========================================
+ Coverage   61.34%   67.04%   +5.70%     
==========================================
  Files         235      246      +11     
  Lines       30049    33918    +3869     
==========================================
+ Hits        18433    22740    +4307     
+ Misses       9778     9305     -473     
- Partials     1838     1873      +35     
Flag Coverage Δ
e2e 46.17% <0.00%> (?)
unittest 61.33% <0.00%> (-0.02%) ⬇️

@HuSharp
Copy link
Contributor Author

HuSharp commented Feb 18, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 19, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Feb 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-19 03:28:34.166847154 +0000 UTC m=+241402.914470258: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit d7861a6 into pingcap:master Feb 19, 2024
13 checks passed
@HuSharp HuSharp deleted the change_get_members branch February 20, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants